allow ProgramPath to be overridable via an environment variable #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16
Hi Mator, when last we talked about #16 (over a brief conversation on discord and then a reddit message), you mentioned that the
Hardcoded.dat
files are going away, so for a while I waited for your new update. Since it's been almost a year now and still no update, I figured I'd give it a stab.I'm hoping that if you're okay with the code, then perhaps this can get the tiniest minor version release (like maybe v0.6.1) built out. With it, there would no longer be a blocker for me uploading my python wrapper to PyPI. Meanwhile when you do get around to removing the
Hardcoded.dat
files, there's no need to preserve this after.I tested this change manually with
GetGlobal
andElementCount
and it seems to have the desired effect. That said, I've never worked with Delphi in my life and just getting it to compile took a few hours. The dll I built out seems to error on some more advanced xedit-lib workflows beyondGetGlobal
andElementCount
, which I chalked up to project configuration issues, but if there's something egregiously wrong with the code please let me know.Thanks,
leontristain