-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement option to copy a tag #924
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- After copying a tag, there is no notification that its a success or failure.
- For tags when we click copy the default container should be the current container
I also faced 1 issue of copy tag throwing and error "This name is already in use" when copying a same tag twice in an another container
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@snake14 The copy notification is getting hidden, if preview mode is enabled
Without preview mode
With preview mode, no notification message is displayed
Thank you for the good review @AltamashShaikh . It looks like I'm going to have to refactor things so that the notifications are handled via Vue instead of PHP, because the PHP notification just doesn't appear to be reliable enough. I thought that I had it selecting the current container by default, but I'll make sure. I have test cases around copying to the same location twice, but I guess I only did that for triggers and variables. I'll add one for tags too and fix the name issue. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now 👍
Description:
This PR implements the ability to copy tags. It tries to reuse existing triggers and variables when copying references from the tag. If no matches exist, any dependencies will be copied as well.
Fixes: #615
Review