Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eff.opam for OCaml 5.2 #88

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ncihnegn
Copy link

@ncihnegn ncihnegn commented Dec 1, 2024

No description provided.

@matijapretnar
Copy link
Owner

Hmmm, I think the GitHub actions need to be updated as well. Also, I prefer to have the OCamlformat version fixed, otherwise the testing is unpredictable. Can you recommend a version that works on OCaml 5, but is still supported on some version of OCaml 4?

@ncihnegn
Copy link
Author

ncihnegn commented Dec 4, 2024

I don't see why CI will fail. Could you please retry it?

@matijapretnar
Copy link
Owner

I think the problem is that this line in GitHub script installs OCaml 4:

uses: avsm/setup-ocaml@v1

@matijapretnar
Copy link
Owner

The tests now fail with

dune build @fmt --auto-promote
File "dune-project", line 22, characters 2-15:
22 |   (ocamlformat)))
       ^^^^^^^^^^^^^
Error: Atom or quoted string expected
make: *** [Makefile:6: format] Error 1

I think it would be best to keep a fixed version of OCamlformat, preferably one that works with both OCaml 4 and 5, if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants