Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ItemDefinition): RecLuq to uint32 on Ep6_4 #58

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Conversation

matigramirez
Copy link
Owner

  • ReqLuc type changed from ushort to uint
  • Read/Write ReqLuc as uint only on Episode 6_4 and above, ushort otherwise
  • Add EP6_4 to Episode enum

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (26519d5) 95.40% compared to head (cc1e249) 95.36%.

Files Patch % Lines
src/Parsec/Shaiya/Item/Item.cs 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   95.40%   95.36%   -0.04%     
==========================================
  Files         167      167              
  Lines        5873     5874       +1     
  Branches      238      239       +1     
==========================================
- Hits         5603     5602       -1     
- Misses        230      231       +1     
- Partials       40       41       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matigramirez matigramirez merged commit 04bf743 into main Feb 7, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant