Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2 commands #262

Merged
merged 2 commits into from
Dec 19, 2024
Merged

v2 commands #262

merged 2 commits into from
Dec 19, 2024

Conversation

marcello33
Copy link
Contributor

Description

In this PR, we change the express-cli commands to work with heimdall-v2

Changes

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • New test case for remote devnet

Checklist

  • I have added at least 2 reviewers or the whole pos-v1 team
  • I have added sufficient documentation in the code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai or amoy

@marcello33 marcello33 merged commit 11f16df into raneet10/heimdallv2-test Dec 19, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pratikspatil024 pratikspatil024 pratikspatil024 approved these changes

@avalkov avalkov avalkov approved these changes

@Raneet10 Raneet10 Awaiting requested review from Raneet10

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcello33 @avalkov @pratikspatil024