add: implement docker e2e ci job #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcello33
changed the title
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.3 to 1.15.4. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.3...v1.15.4) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Raneet10
reviewed
Jan 18, 2024
Raneet10
reviewed
Jan 18, 2024
Raneet10
reviewed
Jan 18, 2024
Thanks for the review @Raneet10 |
marcello33
force-pushed
the
mardizzone/docker-ci
branch
from
a1cca76 to
8ca74f2
Compare
manav2401
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement the docker e2e ci job the same way it is done in
borandheimdall, to make sure the docker setup always work as expected. This also ensuresmatic-clichanges do not affectborandheimdallCIs.The CI now tests:
express-cliin a remote environment on AWSmatic-cliin a dockerized environment locallyThe PR also merges a dependabot PR (see #219)
Changes
Checklist
Testing