Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: matic-cli commands and config update #208

Merged
merged 7 commits into from
Nov 16, 2023
Merged

Conversation

leovct
Copy link
Contributor

@leovct leovct commented Nov 8, 2023

Description

  • Simple update to matic-cli setup commands.
  • Add erigon config to matic-cli docker setup default config file.
  • nit: use working-directory in CI jobs instead of cd commands.

Jira Ticket

Changes

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • New test case for remote devnet

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Cross repository changes

It should never be the case...

  • This PR requires changes to bor
    • In case link the PR here:
  • This PR requires changes to heimdall
    • In case link the PR here:

Testing

  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@leovct leovct force-pushed the chore/matic-cli-updates branch from d6ee7f0 to 7781a17 Compare November 8, 2023 12:03
@leovct leovct changed the title chore: matic-cli commands and config update doc: matic-cli commands and config update Nov 8, 2023
@leovct leovct marked this pull request as ready for review November 8, 2023 12:38
.github/workflows/ci.yml Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/setup/devnet/templates/docker/README.md Show resolved Hide resolved
@leovct leovct requested a review from marcello33 November 14, 2023 09:04
Copy link
Member

@Raneet10 Raneet10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @leovct for the improvements!

@Raneet10 Raneet10 merged commit c7e7e21 into master Nov 16, 2023
5 checks passed
@Raneet10 Raneet10 deleted the chore/matic-cli-updates branch November 16, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants