Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use otelcol-contrib package for traces instead of docker #200

Closed
wants to merge 3 commits into from

Conversation

manav2401
Copy link
Contributor

@manav2401 manav2401 commented Sep 20, 2023

Description

Currently, we used docker image of open collector to parse and send traces to datadog. On our internal nodes, using docker is not advisable (suggestion from devops) and hence we're planning to use the package with a service file. In order to have the same setup on devnets as well, this PR makes changes for the same. Moreover, the config file has been simplified to only have traces and nothing else. As we'll move to coralogix soon, we will have a common config which will handle all the metrics and traces so for now (while we have datadog), we can have a minimalistic config

NOTE: Do not merge - trying to clarify few things from devops.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • New test case for remote devnet

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai

@manav2401 manav2401 marked this pull request as draft September 20, 2023 16:05
@manav2401
Copy link
Contributor Author

Closing this as datadog can send traces directly in a single config.

@manav2401 manav2401 closed this Oct 3, 2023
@manav2401 manav2401 deleted the manav/use-otelcol-contrib-package branch October 3, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants