Skip to content

Commit

Permalink
Merge pull request #261 from VolodymyrBg/Fix-Typos
Browse files Browse the repository at this point in the history
Fix typos
  • Loading branch information
marcello33 authored Dec 18, 2024
2 parents 1035233 + 6038c98 commit fe1129c
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ Please complete this section if any breaking changes have been made, otherwise d

# Checklist

- [ ] I have added at least 2 reviewer or the whole pos-v1 team
- [ ] I have added sufficient documentation in code
- [ ] I have added at least 2 reviewers or the whole pos-v1 team
- [ ] I have added sufficient documentation in the code
- [ ] I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

# Cross repository changes
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ The `express-cli` also comes with additional utility commands, listed below. Som
- `../../bin/express-cli.js --update-erigon [index]`

- Fetches `erigon` branch defined as `ERIGON_BRANCH` in `.env.devnet<id>` file, pulls relative changes and restarts it on
the remote machines. If an integer `index` is used, the job will be performed only on the VM corresponding to that index. For example if the devnet consists of 2 bor and erigon nodes and you wanted to target the first erigon node, `index` will be 2.
the remote machines. If an integer `index` is used, the job will be performed only on the VM corresponding to that index. For example, if the devnet consists of 2 bor and erigon nodes and you want to target the first erigon node, `index` will be 2.

- `../../bin/express-cli.js --update-heimdall [index]`

Expand Down
2 changes: 1 addition & 1 deletion docs/milestones.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## Simulation tests for milestones

Milestone feature in the PoS V1 chain aims to make the finality of chain more deterministic rather than probabilistic. As it introduces explicit finality, it affects lot of people operating on the chain. The simulation based tests helps to generate different scenarios and test the feature effectively.
Milestone feature in the PoS V1 chain aims to make the finality of chain more deterministic rather than probabilistic. As it introduces explicit finality, it affects lot of people operating on the chain. The simulation based tests help to generate different scenarios and test the feature effectively.

### Branches to use and some exceptions

Expand Down
2 changes: 1 addition & 1 deletion secret.tfvars.example
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# 1. Copy this file to secret.tfvar (e.g. `cp secret.tfvars.example secret.tfvars`)
# 2. Modify secret.tfvars by replacing the following with the list of IPs you want to allow
# 3. For Polygon employees, these would be Bastillion and VPN IP addresses
# 4. If you don't know what are Bastillion and VPN IP addresses, please ask to the PoS team (ref. [email protected])
# 4. If you don't know what are Bastillion and VPN IP addresses, please ask the PoS team (ref. [email protected])
# NOTE for Polygon employees: Do NOT use "0.0.0.0/0" for security reasons, otherwise the admin port will be open to the Internet!

SG_CIDR_BLOCKS=["1.2.3.4/0", "5.6.7.8/0"]
2 changes: 1 addition & 1 deletion src/setup/devnet/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ export class Devnet {
this.config.targetDirectory
)

// TODO: Uncomment when finalised for docker setup
// TODO: Uncomment when finalized for docker setup
// if (this.config.network) {
// const chain = this.config.network
// for (let i = 0; i < this.totalBorNodes; i++) {
Expand Down

0 comments on commit fe1129c

Please sign in to comment.