This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 505
Contracts management #391
Open
imyourm8
wants to merge
58
commits into
main
Choose a base branch
from
contracts-management
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Contracts management #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have disabled tests for contracts we don't use in production. Such as all predicates except Burn Only. Draining of the stake manager too, it uses Gnosis Safe there, which suddenly fails now, due to broken signing.
Update current release file and include storage layouts.
Used previously in truffle migrations
Finished release flow
morenoh149
reviewed
Dec 6, 2021
@@ -1,6 +1,6 @@ | |||
pragma solidity ^0.5.2; | |||
|
|||
import {RootChainStorage} from "./RootChainStorage.sol"; | |||
import {RootChainStorage} from "./RootChainStorage.sol"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added trailing whitespace?
Zackaryjacob
approved these changes
Jun 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to improve the way our smart contracts are deployed, updated, and verified to improve the overall quality and quality of life.
List of major changes: