Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A11y tree explorer #308

Merged
merged 17 commits into from
Aug 21, 2019
Merged

A11y tree explorer #308

merged 17 commits into from
Aug 21, 2019

Conversation

zorkow
Copy link
Member

@zorkow zorkow commented Jul 3, 2019 •
edited
Loading

PR takes care of a number of points in issue #303

  • Implements tree explorers: Instances are the Tree-coloring and the old Flamer.
  • Integrates all explorers fully with the menu.
  • Moves the A11y menu elements to the position we had already discussed.
  • A11y options are fully set in the a11y code only.

There are still some restart issues in particular on collapse/expand actions, which will be done with custom events as discussed.

zorkow added 16 commits June 24, 2019 11:00
@zorkow
Integrates a11y settings into menu.
f85358f
@zorkow
Partial integration into Menu.
6a999db
@zorkow
Merge branch 'a11y_explorer_refactor' into a11y_integrate_menu
954956d
@zorkow
Merge branch 'a11y_integrate_menu' into a11y_restructure_menu
3cc2e8e
@zorkow
Merge branch 'a11y_explorer_refactor' into a11y_integrate_menu
d36e000
@zorkow
Merge branch 'a11y_integrate_menu' into a11y_restructure_menu
9f56f03
@zorkow
Adds TreeExplorer class.
efc328d
@zorkow
Implements tree coloring.
cd8e881
@zorkow
Refactors speech generator generation.
1f420bc
@zorkow
Separates initialisation and attachment of explorers.
580f309
@zorkow
Integrates explorers into menu with correct restart.
719ca1e
@zorkow
Moves explorer menu into top level accessibility menu.
9b7c004
@zorkow
Moves A11y options fully to explorer module.
f4a7731
@zorkow
Uses activation for tree explorers.
3abf9ec
@zorkow
Integrates magnify variable for hover region.
b7c93df
@zorkow
Merge branch 'master' into a11y_tree_explorer
c678789
@zorkow zorkow requested a review from dpvc July 3, 2019 12:29
dpvc
dpvc approved these changes Jul 3, 2019
View reviewed changes
Copy link
Member

@dpvc dpvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only cosmetic suggestions. Take them or leave them.

mathjax3-ts/a11y/explorer.ts Show resolved Hide resolved
mathjax3-ts/a11y/explorer.ts Show resolved Hide resolved
mathjax3-ts/a11y/explorer.ts Show resolved Hide resolved
mathjax3-ts/a11y/explorer.ts Show resolved Hide resolved
mathjax3-ts/ui/menu/Menu.ts Show resolved Hide resolved
mathjax3-ts/ui/menu/Menu.ts Show resolved Hide resolved
@zorkow
Copy link
Member Author

zorkow commented Aug 21, 2019

camelCased everything uniquely and renamed menu items as suggests.

@zorkow zorkow merged commit c9e7253 into master Aug 21, 2019
@zorkow zorkow deleted the a11y_tree_explorer branch August 21, 2019 10:04
@zorkow zorkow restored the a11y_tree_explorer branch August 21, 2019 10:04
@zorkow zorkow mentioned this pull request Aug 21, 2019
Closed
@zorkow
Copy link
Member Author

zorkow commented Aug 21, 2019

Darn, I just merged before pushing all my changes. Sorry, I will fix it in the reverted branch.

@zorkow zorkow mentioned this pull request Aug 21, 2019
Merged
@zorkow
Copy link
Member Author

zorkow commented Aug 21, 2019

Fixed it in #327 instead. That was easier than messing about with reverting branches etc!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpvc dpvc dpvc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zorkow @dpvc