Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of Locale framework #1122

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Initial implementation of Locale framework #1122

wants to merge 3 commits into from

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Jul 27, 2024

This is a draft for the Locale framework. I will add a better description here later, but wanted to make this available in case you wanted to look at it.

The bbox extension is an example of this in use (it changes one error message so you can see that it is working).

It is probably best to look at the BBoxConfiguration.ts file with what space being ignored, as it was not properly indented originally.

This should work both in components and direct calls, both in the browser and in node applications. The interactive lab needs minor additions because of the unusual way that it is handling the TeX extensions. I will make a branch for that in the dev repo.

More details to come.

… to handle json files, and simplifications for components/bin/copy config data
@dpvc dpvc marked this pull request as draft July 27, 2024 00:29
dpvc added 2 commits July 26, 2024 20:35
… remove English default messages and use the en loclaization for them. These were requested by Volker's review.
@dpvc
Copy link
Member Author

dpvc commented Aug 22, 2024

I have made the changes that we talked about in our meeting today. This now tries to load localization files from any component that registers with the Local object, and the error functions no longer include the English messages. Instead, the message look-up tries to find the value from the current locale, and if that fails, looks in the default locale, which is en, but can be changed if desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant