Prevent onClick properly when controlled

mathieudutour · Jun 7, 2019 · de29340 · de29340
1 parent a4e0f24
commit de29340
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/index.js b/src/index.js
@@ -114,15 +114,15 @@ const ProgressButton = createReactClass({
   },
 
   handleClick (e) {
-    if (this.props.controlled) {
+    const shouldAllowClick = (this.props.shouldAllowClickOnLoading ||
+        this.state.currentState !== STATE.LOADING) &&
+        this.state.currentState !== STATE.DISABLED
+    if (this.props.controlled && shouldAllowClick) {
       this.props.onClick(e)
       return true
     }
 
-    if ((this.props.shouldAllowClickOnLoading ||
-        this.state.currentState !== STATE.LOADING) &&
-        this.state.currentState !== STATE.DISABLED
-    ) {
+    if (shouldAllowClick) {
       this.loading()
       const ret = this.props.onClick(e)
       this.handlePromise(ret)