Added Averaging Neural Operator with tests and a tutorial #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndem0
requested changes
Feb 9, 2024
dario-coscia
requested changes
Feb 9, 2024
dario-coscia
added
enhancement
|
Please look at #239 for using the same strategy. Also use |
guglielmopadula
force-pushed
the
master
branch
from
51409b0 to
8e6cea1
Compare
ndem0
approved these changes
Feb 21, 2024
ndem0
reviewed
Feb 21, 2024
ndem0
requested changes
Feb 21, 2024
dario-coscia
requested changes
Feb 21, 2024
dario-coscia
requested changes
Mar 4, 2024
|
Only remaining issue is codacy complaining about the AVNOBlock class having too few public methods, which I think is unfixable. |
|
What's the status here? |
guglielmopadula
force-pushed
the
master
branch
2 times, most recently
from
dbe389c to
377dae8
Compare
|
Very good! I will make some minor changes and then we can merge! |
ndem0
approved these changes
Mar 5, 2024
dario-coscia
approved these changes
Mar 5, 2024
dario-coscia
added
pr-to-review
|
@ndem0 for me everything is ok, @guglielmopadula did an amazing job! I made some minor corrections (checking the type of the input objects, and modifying a bit the doc to make it consistent with the package). Ready to go! |
AleDinve
pushed a commit
to AleDinve/PINA
that referenced
this pull request
Mar 25, 2024
* add Averaging Neural Operator with tests * add backward test * minor changes * doc addition --------- Co-authored-by: Dario Coscia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Averaging Neural Operator with tests and a tutorial
(details about the model are in https://arxiv.org/abs/2304.13221)