Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solvers logging #202

Merged
merged 5 commits into from
Nov 8, 2023
Merged

Solvers logging #202

merged 5 commits into from
Nov 8, 2023

Conversation

dario-coscia
Copy link
Collaborator

Solving issue #201

Dario Coscia added 2 commits November 7, 2023 12:13
Modifying solvers to log every epoch correctly
05050f4 
* add `on_epoch` flag to logger
* fix bug in `pinn.py` `pts -> samples` in `_loss_phys`
* add `optimizer_zero_grad()` in garom generator training loop
* modify imports in `callbacks.py`
fixing tests
4023eb0
@dario-coscia dario-coscia requested a review from ndem0 November 7, 2023 11:23
@dario-coscia dario-coscia added pr-to-review Label for PR that are ready to been reviewed v0.2 implementation in v0.2 labels Nov 7, 2023
ndem0
ndem0 reviewed Nov 7, 2023
View reviewed changes
Copy link
Member

@ndem0 ndem0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, just open an issue with the failing test and we'll merge!

@dario-coscia
Copy link
Collaborator Author

Please, just open an issue with the failing test and we'll merge!

Hi @ndem0 I fixed a small bug in adaptive_refinment_callbacks.py to assert that the points we are retaining are not all empty tensor. Indeed, if points are empty .label in __getitem__ would raise an error. Now the errors are all due to issue #200 (as you can see only python 3.7 does not work)

@dario-coscia dario-coscia mentioned this pull request Nov 8, 2023
Merged
@ndem0 ndem0 merged commit c3a80e2 into v0.1 Nov 8, 2023
10 of 14 checks passed
@dario-coscia dario-coscia deleted the solvers_logging branch November 9, 2023 09:45
This was referenced Nov 9, 2023
Closed
Merged
ndem0 pushed a commit that referenced this pull request Nov 17, 2023
@dario-coscia @ndem0
Solvers logging (#202)
3f9305d 
* Modifying solvers to log every epoch correctly
* add `on_epoch` flag to logger
* fix bug in `pinn.py` `pts -> samples` in `_loss_phys`
* add `optimizer_zero_grad()` in garom generator training loop
* modify imports in `callbacks.py`
* fixing tests

---------

Co-authored-by: Dario Coscia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndem0 ndem0 ndem0 left review comments

Assignees
No one assigned
Labels
pr-to-review Label for PR that are ready to been reviewed v0.2 implementation in v0.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dario-coscia @ndem0