Store.connect: fix force_reset kwarg implementations #879
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR increases the consistency of
force_reset
kwarg inStore.connect()
acrossStore
classes. It was motivated by an observation that on systems with slow storage, connecting to aJSONStore
can take a long time. If one has already connected to theStore
, a subsequent call toconnect
(with force_reset=False) should not cause the entire connection process to repeat.This PR enforces the paradigm that we don't need to re-instantiate clients, reset ssh tunnels, or re-read data files if a store has already connected and force_reset=False.
Checklist
ruff
. (For guidance in fixing rule violates, see rule list)mypy
.