Change default callback_filter in update_metadata #721
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the default value of
callback_filter
in theupdate_metadata
function of bothJob
andFlow
from a lambda toNone
. Having its default value be a lamdba function means that it cannot be round-trip de-/serialized:This causes issues in fireworks with the newest release of jobflow. Linking relevant discussion here and tagging @janosh and @utf for thoughts
Because lambda's aren't pickle-able without something like dill, writing a
callback_filter
as an importable function might be the only option for fireworks / jobflow users