Implement HTTPS support as well as ability to pass arbitrary curl options #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
still getting SOAP-ERROR: Parsing WSDL: Couldn't load from 'https://xxxxx.com/?wsdl' : failed to load external entity "https://xxxxx.com/?wsdl" |
|
I just tried this in a real project with NTLM auth over https, and it worked like a charm. Thanks for the Code @jasonhildebrand |
|
Thanks @josefbehr for the comment. I'm still actively using this project too (with my patch). It would be nice to see it merged in. |
|
@matejsvajger Can you make a statement? I need the ssl connection, too. I tested the pull request successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added support for HTTPS streams as well as passing additional options to curl.
It is sometimes necessary to pass additional curl options, for example to connect to a service which uses a self-signed certificate. This lets users pass these options without modifying the code.