Merge pull request #35 from matecat/remove-singlecurlybracketstoph

Removed `SingleCurlyBracketsToPh` from Uber pipeline
matecat · Jul 26, 2023 · 0d451eb · 0d451eb
2 parents 854143f + cf0d211
commit 0d451eb
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 49 deletions.
diff --git a/src/MyMemoryFilter.php b/src/MyMemoryFilter.php
@@ -26,7 +26,6 @@
 use Matecat\SubFiltering\Filters\RestoreXliffTagsContent;
 use Matecat\SubFiltering\Filters\RestoreXliffTagsInXliff;
 use Matecat\SubFiltering\Filters\RubyOnRailsI18n;
-use Matecat\SubFiltering\Filters\SingleCurlyBracketsToPh;
 use Matecat\SubFiltering\Filters\SmartCounts;
 use Matecat\SubFiltering\Filters\Snails;
 use Matecat\SubFiltering\Filters\SplitPlaceholder;
@@ -86,10 +85,6 @@ public function fromLayer0ToLayer1( $segment, $cid = null ) {
         $channel->addLast( new RestoreXliffTagsContent() );
         $channel->addLast( new RestorePlaceHoldersToXLIFFLtGt() );
 
-        if ( $cid == 'uber' ) {
-            $channel->addAfter( new TwigToPh(), new SingleCurlyBracketsToPh() );
-        }
-
         return $channel->transform( $segment );
 
     }

diff --git a/tests/MateCatSubFilteringTest.php b/tests/MateCatSubFilteringTest.php
@@ -10,7 +10,6 @@
 use Matecat\SubFiltering\Filters\TwigToPh;
 use Matecat\SubFiltering\MateCatFilter;
 use Matecat\SubFiltering\Tests\Mocks\Features\AirbnbFeature;
-use Matecat\SubFiltering\Tests\Mocks\Features\UberFeature;
 use Matecat\SubFiltering\Tests\Mocks\FeatureSet;
 use Matecat\SubFiltering\Utils\CatUtils;
 use PHPUnit\Framework\TestCase;
@@ -783,21 +782,6 @@ public function testSmartCount() {
      **************************
      */
 
-    public function testWithUberPipeline() {
-        $Filter = MateCatFilter::getInstance( new FeatureSet( [ new UberFeature() ] ), 'en-EN', 'et-ET', [] );
-
-        $db_segment          = 'Ciao questo è una prova {RIDER}. { RIDER } non viene bloccato.';
-        $expected_l1_segment = 'Ciao questo è una prova <ph id="mtc_1" ctype="' . CTypeEnum::CURLY_BRACKETS . '" equiv-text="base64:e1JJREVSfQ=="/>. { RIDER } non viene bloccato.';
-
-        $l1_segment = $Filter->fromLayer0ToLayer1( $db_segment );
-
-        $this->assertEquals( $l1_segment, $expected_l1_segment );
-
-        $back_to_db_segment = $Filter->fromLayer1ToLayer0( $l1_segment );
-
-        $this->assertEquals( $back_to_db_segment, $db_segment );
-    }
-
     /**
      * Test for skyscanner
      * (promoted to global behavior)

diff --git a/tests/Mocks/Features/UberFeature.php b/tests/Mocks/Features/UberFeature.php
diff --git a/tests/MyMemorySubFilteringTest.php b/tests/MyMemorySubFilteringTest.php
@@ -229,10 +229,8 @@ public function testWithSquareSprintf() {
             '[%.222f:name]',
             '[%.2f:placeholder]',
             '[%.2f:place_holder]',
-            '[%key_id:key_id%]',
             '[%key_id:1234%]',
             '[%test:1234%]',
-            '[%test:test%]',
         ];
 
         foreach ($tags as $tag){