Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task solution #2017

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

task solution #2017

wants to merge 2 commits into from

Conversation

W3zzie
Copy link

@W3zzie W3zzie commented Sep 24, 2024

Copy link

@Zibi95 Zibi95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 🥇 . I have left some comments for future reference.

Comment on lines +9 to +13
export const UserInfo: React.FC<Props> = ({ user }) => (
<a className="UserInfo" href={`mailto:${user?.email}`}>
{user?.name}
</a>
);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Destructure user object


export const CommentList: React.FC = () => <>Put the list here</>;
export const CommentList: React.FC<{ comments: Comment[] }> = ({
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you declare the type interface and once you do not, stay consistent with your approach.


export const CommentInfo: React.FC = () => <>Put the comment here</>;
export const CommentInfo: React.FC<{ comment: Comment }> = ({
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants