add task solution #2012
Open
add task solution #2012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natalia-klonowska
suggested changes
Jul 2, 2024
src/App.tsx
Outdated
| <div className="PostInfo"> | ||
| <div className="PostInfo__header"> | ||
| <h3 className="PostInfo__title">doloremque illum aliquid sunt</h3> | ||
| function getUser(userId: number): User | null { |
There was a problem hiding this comment.
If you are searching some entity by some filter, specify it in function/method name [checklist]
Suggested change
| function getUser(userId: number): User | null { | |
| function getUserById(userId: number): User | null { |
Zibi95
approved these changes
Jul 5, 2024
| type Props = { | ||
| comment: Comment; | ||
| }; | ||
| export const CommentInfo: React.FC<Props> = ({ comment }) => ( |
There was a problem hiding this comment.
Use destructuring whenever you are able to.
| post: Post; | ||
| }; | ||
|
|
||
| export const PostInfo: React.FC<Props> = ({ post }) => ( |
| user: User; | ||
| }; | ||
|
|
||
| export const UserInfo: React.FC<Props> = ({ user }) => ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK