Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task resolved #2000

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Task resolved #2000

wants to merge 2 commits into from

Conversation

bartKarb
Copy link

Copy link

@pawelkloc pawelkloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you write the code this way: export const CommentInfo: React.FC<{ comment: Comment }> = ({ comment })

, and once you write it that way: `type Props = {
comments: Comment[];
};

export const CommentList: React.FC = ({ comments })
` Try to be more consistent and choose one style of writing code, ok? :) E.g. use props because they are more readable ;)

@bartKarb
Copy link
Author

I just unified styles of the code, however i picked
export const CommentInfo: React.FC<{ comment: Comment }> = ({ comment })
style over the other one - somehow it's more understandable for me, and I feel better with it - at least for now.

@bartKarb bartKarb requested a review from pawelkloc March 26, 2024 09:02
Copy link

@pawelkloc pawelkloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants