solution #1988
solution #1988
Conversation
|
|
||
| return ( | ||
| <div className="CommentList"> | ||
| {comments.map(comment => ( |
There was a problem hiding this comment.
It's better to extract properties from comment here and pass them separately into the component, like
({ name }) => (<CommentInfo name={name} />)
src/components/PostList/PostList.tsx
Outdated
|
|
||
| export const PostList: React.FC<Props> = ({ posts }) => ( | ||
| <div className="PostList"> | ||
| {posts.map(post => ( |
|
The demo looks now the same, but I'm having issues with the tests. |
There was a problem hiding this comment.
it('should have a link with mailto: user.email', () => {
const user1 = {
id: 1,
name: 'Leanne Graham',
username: 'Bret',
email: '[email protected]',
};
mount(<UserInfo user={user1} />);
cy.get('.UserInfo').should('have.attr', 'href', 'mailto:[email protected]');
});
Yep, noticed that thing with tests. They are expecting to receive the user object within the component.
But hey, you are a developer here, give 'em hell, fill free to change it :)
mount(<UserInfo name={user1.name} email={user1.email} />);
This is a minor adjustment to a testcase, but it makes sense due to your changes.
In this case, taking test cases into consideration, I have misguided you a bit, however, I am still convinced that it's always better to pass separate props than the object into a component whenever it's possible (and also a good practice to check and modify tests if you will).
Anyways, great job! Don't hesitate to change the world as you like it, no need to always play by the rules stated by others. 🥇
DEMO LINK