Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task solved #1960

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

task solved #1960

wants to merge 5 commits into from

Conversation

TommasoGiacopini
Copy link

@TommasoGiacopini TommasoGiacopini commented Nov 29, 2023 •
edited
Loading

lerastarynets
lerastarynets suggested changes Nov 29, 2023
View reviewed changes
Copy link

@lerastarynets lerastarynets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, your project is not reachable via the demo link(

@TommasoGiacopini
Copy link
Author

Hello, I don't know why, but locally the tests are passing. I'm attaching screenshots. Please approve the task.
Screenshot 2023-11-29 at 10 38 03
Screenshot 2023-11-29 at 10 38 05

lerastarynets
lerastarynets suggested changes Nov 30, 2023
View reviewed changes
Copy link

@lerastarynets lerastarynets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are not the problem here, the problem is that mentors are unable to see deployed version of your project, so pls deploy it and rerequest the review

@TommasoGiacopini
Copy link
Author

Okay, now it should work!

witflash
witflash approved these changes Dec 3, 2023
View reviewed changes
Copy link

@witflash witflash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code looks pretty good!
Well done! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@witflash witflash witflash approved these changes

@lerastarynets lerastarynets Awaiting requested review from lerastarynets

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TommasoGiacopini @witflash @lerastarynets