-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solution #2776
base: master
Are you sure you want to change the base?
solution #2776
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on implementing the task requirements! 🎉 While there are a couple of issues that need attention, such as ensuring the Person
component is correctly imported and adjusting how partner details are accessed, these are minor and don't significantly impact the core functionality. Keep up the good work, and consider these improvements for future projects! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
<Person person={misha} /> | ||
<Person person={olya} /> | ||
<Person person={alex} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Person
component is used here but is not imported or defined in this file. Make sure to import the Person
component from its respective file or define it within this file to avoid runtime errors.
src/components/Person/Person.jsx
Outdated
<p className="Person__partner"> | ||
{person.isMarried ? | ||
`${person.partner.name} is my | ||
${person.partner.sex === 'f' ? | ||
"wife": | ||
"husband"}` : | ||
"I am not married"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The person.partner.name
and person.partner.sex
properties are accessed here, but the person
object does not have a partner
property in the current structure. You should access person.partnerName
and use a condition to determine the partner's sex based on the person.sex
property.
DEMO LINK