Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add task solution #2773

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add task solution #2773

wants to merge 1 commit into from

Conversation

naz4ik
Copy link

@naz4ik naz4ik commented Dec 28, 2024

mateacademy-ai-mentor
mateacademy-ai-mentor approved these changes Dec 28, 2024
View reviewed changes
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the task! 🎉 The Person component is correctly implemented and used in the App component as required. The styling is well-organized, and the code adheres to the task requirements. Just make sure to double-check the import path for the Person component to avoid any potential rendering issues. Keep up the excellent work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

src/App.jsx
@@ -1,6 +1,8 @@
import React from 'react';
import './App.scss';

import { Person } from './components/Person/Person';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the Person component is correctly implemented and exported from './components/Person/Person'. If there are any issues with the import path or the component itself, it may cause rendering problems.

vadiimvooo
vadiimvooo approved these changes Dec 28, 2024
View reviewed changes
Copy link

@vadiimvooo vadiimvooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateacademy-ai-mentor mateacademy-ai-mentor mateacademy-ai-mentor approved these changes

@vadiimvooo vadiimvooo vadiimvooo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@naz4ik @vadiimvooo @mateacademy-ai-mentor