Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #2759

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #2759

wants to merge 1 commit into from

Conversation

Tomarikaa
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the Person component and ensuring it meets the task requirements! 🎉 The code is functional and adheres to the specifications. While there is a minor issue with potentially undefined properties like age and partnerName, it doesn't critically impact the functionality. Consider adding default values or handling these cases in the future to make your code more robust. Keep up the good work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

<p className="Person__partner">Natasha is my wife</p>
</section>
const Person = ({ person }) => {
const { name, age, sex, isMarried, partnerName } = person;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The age and partnerName properties are destructured from the person object, but they are not present in all person objects (e.g., olya does not have an age property). This might lead to undefined values being used. Consider providing default values or handling undefined cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants