Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #2731

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

solution #2731

wants to merge 1 commit into from

Conversation

AndreaTkachuk
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the task requirements! 🎉 The code is functional and meets all the core requirements. While there's a minor point regarding the default assignment of the partner variable, it doesn't impact the overall functionality. Consider initializing partner as null or handling both cases within the conditional block for improved clarity. Keep up the good work and continue refining your skills! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

// export const Person = ({ person }) => ();
export const Person = ({ person }) => {
const { name, age, partnerName, isMarried, sex } = person;
let partner = <p className="Person__partner">{partnerName} is my husband</p>;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default assignment of the partner variable assumes the person is female. It might be clearer to initialize partner as null or handle both cases within the conditional block to avoid assumptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants