-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution Inga Tkachuk #2717
base: master
Are you sure you want to change the base?
Solution Inga Tkachuk #2717
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on implementing the task requirements! 🎉 The code is mostly correct and meets the core requirements. There are a couple of minor issues to address: correcting the typo in the variable name parthner
to partner
for better readability, and ensuring the Person
component is correctly defined and exported to avoid potential errors. These are small improvements and do not affect the overall functionality. Keep up the good work and happy coding! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
@@ -1,5 +1,6 @@ | |||
import React from 'react'; | |||
import './App.scss'; | |||
import { Person } from './components/Person/Person'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the Person
component is correctly defined and exported in the ./components/Person/Person
file. If not, it will cause an error when rendering the App
component.
src/components/Person/Person.jsx
Outdated
import React from 'react'; | ||
|
||
export const Person = ({ person }) => { | ||
const parthner = person.sex === 'm' ? 'wife' : 'husband'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo in the variable name parthner
. It should be partner
to improve code readability.
No description provided.