Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution Inga Tkachuk #2717

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Solution Inga Tkachuk #2717

wants to merge 2 commits into from

Conversation

IDWIL8
Copy link

@IDWIL8 IDWIL8 commented Nov 28, 2024

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the task requirements! 🎉 The code is mostly correct and meets the core requirements. There are a couple of minor issues to address: correcting the typo in the variable name parthner to partner for better readability, and ensuring the Person component is correctly defined and exported to avoid potential errors. These are small improvements and do not affect the overall functionality. Keep up the good work and happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

@@ -1,5 +1,6 @@
import React from 'react';
import './App.scss';
import { Person } from './components/Person/Person';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the Person component is correctly defined and exported in the ./components/Person/Person file. If not, it will cause an error when rendering the App component.

import React from 'react';

export const Person = ({ person }) => {
const parthner = person.sex === 'm' ? 'wife' : 'husband';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the variable name parthner. It should be partner to improve code readability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants