Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #2710

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

pasha28091997
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the task requirements! 🎉 The Person component is well-designed to handle optional properties like age and partnerName, ensuring flexibility. The code meets all the core requirements, and the use of destructuring and conditional rendering is spot on. Keep up the good work! If you want to further enhance your code, consider adding default values or handling for missing properties to make it even more robust. 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +14 to +19
const olya = {
name: 'Olya',
sex: 'f',
isMarried: true,
partnerName: 'Maksym',
};

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The olya object is missing the age property. Ensure that the Person component can handle objects without an age property or add an age property to olya.

Comment on lines +21 to +26
const alex = {
name: 'Alex',
age: 25,
sex: 'm',
isMarried: false,
};

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alex object is missing the partnerName property. Ensure that the Person component can handle objects without a partnerName property or add a partnerName property to alex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants