Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solution #2702

Closed
wants to merge 1 commit into from
Closed

solution #2702

wants to merge 1 commit into from

Conversation

Fridrif27
Copy link

mateacademy-ai-mentor
mateacademy-ai-mentor approved these changes Nov 19, 2024
View reviewed changes
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the task requirements! 🎉 The code is well-structured and meets the core functionality. Just a small suggestion: consider adding a check for partnerName in the Person component to handle cases where it might be undefined, like with alex. Keep up the great work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

src/components/Person/Person.jsx

const partnerRelation = person.sex === 'm' ? 'wife' : 'husband';

return `${person.partnerName} is my ${partnerRelation}`;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider handling the case where person.partnerName might be undefined, as in the case of alex. You could add a check to ensure that partnerName is defined before using it in the string template.

BudnikOleksii
BudnikOleksii approved these changes Nov 21, 2024
View reviewed changes
Copy link

@BudnikOleksii BudnikOleksii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Fridrif27 Fridrif27 closed this by deleting the head repository Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateacademy-ai-mentor mateacademy-ai-mentor mateacademy-ai-mentor approved these changes

@BudnikOleksii BudnikOleksii BudnikOleksii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fridrif27 @BudnikOleksii @mateacademy-ai-mentor