Solution #2694
Open
Solution #2694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateacademy-ai-mentor
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Great job! 🎉 Your implementation meets all the task requirements and constraints perfectly. The components are well-structured, and you've handled props and conditional rendering effectively. Keep up the excellent work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
BudnikOleksii
suggested changes
Nov 21, 2024
src/App.jsx
Outdated
|
|
||
| <section className="Person"> | ||
| {/* <section className="Person"> |
src/components/Person/Person.jsx
Outdated
| @@ -1 +1,24 @@ | |||
| // export const Person = ({ person }) => (); | |||
| export const Person = ({ person }) => { | |||
| let marriedLabel = <p className="Person__partner">I am not married</p>; | |||
There was a problem hiding this comment.
You have <p className="Person__partner"> in all cases
src/components/Person/Person.jsx
Outdated
Comment on lines
5
to
13
| if (person.sex === 'm' && person.isMarried) { | ||
| marriedLabel = ( | ||
| <p className="Person__partner">{person.partnerName} is my wife</p> | ||
| ); | ||
| } | ||
|
|
||
| if (person.sex === 'f' && person.isMarried) { | ||
| marriedLabel = ( | ||
| <p className="Person__partner">{person.partnerName} is my husband</p> |
There was a problem hiding this comment.
Try to simplify to avoid repeating
VolodymyrKirichenko
approved these changes
Nov 22, 2024
Comment on lines
+10
to
+12
| <h2 className="Person__name">My name is {person.name}</h2> | ||
| {person.age && <p className="Person__age">I am {person.age}</p>} | ||
| <p className="Person__partner">{marriedLabel}</p> |
There was a problem hiding this comment.
Don't forget about indents(more readable)
Suggested change
| <h2 className="Person__name">My name is {person.name}</h2> | |
| {person.age && <p className="Person__age">I am {person.age}</p>} | |
| <p className="Person__partner">{marriedLabel}</p> | |
| <h2 className="Person__name">My name is {person.name}</h2> | |
| {person.age && ( | |
| <p className="Person__age">I am {person.age}</p> | |
| )} | |
| <p className="Person__partner">{marriedLabel}</p> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK