Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solution #2678

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

solution #2678

wants to merge 2 commits into from

Conversation

Ilya-Ilchuk
Copy link

@Ilya-Ilchuk Ilya-Ilchuk commented Nov 18, 2024 •
edited
Loading

mateacademy-ai-mentor
mateacademy-ai-mentor approved these changes Nov 18, 2024
View reviewed changes
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code is well-structured and meets all the task requirements! 🎉 The App.jsx and Person.jsx components are implemented correctly, and you've used destructuring and conditional rendering effectively. Great job! Keep up the good work and continue to refine your skills. 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

BudnikOleksii
BudnikOleksii approved these changes Nov 21, 2024
View reviewed changes
Copy link

@BudnikOleksii BudnikOleksii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/components/Person/Person.jsx Outdated
<h2 className="Person__name">My name is {name}</h2>
{age && <p className="Person__age">I am {age}</p>}
{isMarried ? (
<p className="Person__partner">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have <p className="Person__partner"> in all cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateacademy-ai-mentor mateacademy-ai-mentor mateacademy-ai-mentor approved these changes

@BudnikOleksii BudnikOleksii BudnikOleksii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ilya-Ilchuk @BudnikOleksii @mateacademy-ai-mentor