Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #2615

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

solution #2615

wants to merge 3 commits into from

Conversation

YevhenRDoIT
Copy link

src/components/Person/Person.jsx Outdated Show resolved Hide resolved
@YevhenRDoIT YevhenRDoIT requested a review from etojeDenys October 1, 2024 06:56
@YevhenRDoIT
Copy link
Author

I have updated to suggested code and thank you

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, now your tests are failed, you need to fix it and update demo link
image

<section className="Person">
<h2 className="Person__name">My name is {name}</h2>
{age && <p className="Person__age">I am {age}</p>}
{isMarried ? personPartnerType : personPartner}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the tag p with this class as wrapper
image

@YevhenRDoIT
Copy link
Author

I have fixed the issues and update solution. Thank you

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants