Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solutionPerson #1860

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

solutionPerson #1860

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37bfb72
solutionPerson
Dmytrosp Nov 16, 2023
80d84a2
fix
Dmytrosp Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 23 additions & 16 deletions src/App.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import React from 'react';
import './App.scss';

import { Person } from './components/Person/Person';

export const misha = {
name: 'Misha',
age: 37,
Expand All @@ -25,21 +27,26 @@ export const alex = {

export const App = () => (
<div className="App">
<section className="Person">
<h2 className="Person__name">My name is Misha</h2>
<p className="Person__age">I am 37</p>
<p className="Person__partner">Natasha is my wife</p>
</section>

<section className="Person">
<h2 className="Person__name">My name is Olya</h2>
<p className="Person__partner">Maksym is my husband</p>
</section>

<section className="Person">
<h2 className="Person__name">My name is Alex</h2>
<p className="Person__age">I am 25</p>
<p className="Person__partner">I am not married</p>
</section>

<Person
name="Misha"
age={37}
sex="m"
isMarried
partnerName="Natasha"
/>

<Person
name="Olya"
sex="f"
isMarried
partnerName="Maksym"
/>

<Person
name="Alex"
age={25}
sex="m"
/>
</div>
);
36 changes: 35 additions & 1 deletion src/components/Person/Person.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,35 @@
// export const Person = ({ person }) => ();
export const Person = ({
name,
age = 0,
sex,
isMarried,
partnerName,
}) => (
<>
<section className="Person">

<h2 className="Person__name">
{`My name is ${name}`}
</h2>

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can put in into one line

<p className="Person__age">
{age > 0 && (`I am ${age}`)
}
</p>

<p className="Person__partner">
{isMarried && sex === 'm' && (
`${partnerName} is my wife`
)}

{isMarried && sex === 'f' && (
`${partnerName} is my husband`
)}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks too complicated, create a separate variable for person partnet

const partnet = person.sex === 'm' ? 'wife' : 'husband'

And use this variable in your template


{!isMarried && (
`I am not married`
)}
</p>
</section>
</>
);
Loading