react_person_solituon #1834
Open
react_person_solituon #1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viktor-Kost
suggested changes
Nov 7, 2023
src/components/Person/Person.jsx
Outdated
Comment on lines
1
to
4
| export const Person = ({ | ||
| person, | ||
| }) => ( | ||
| <section className="Person"> |
There was a problem hiding this comment.
it's a good practice to use object destructing
Suggested change
| export const Person = ({ | |
| person, | |
| }) => ( | |
| <section className="Person"> | |
| export const Person = ({ person }) => { | |
| const { name, age, ... } = person; | |
| return ( | |
| <section className="Person"> |
src/components/Person/Person.jsx
Outdated
| }) => ( | ||
| <section className="Person"> | ||
| <h2 className="Person__name"> | ||
| {`My name is ${person.name}`} |
There was a problem hiding this comment.
no needs to use a template string
Suggested change
| {`My name is ${person.name}`} | |
| My name is {name} |
src/components/Person/Person.jsx
Outdated
| {`My name is ${person.name}`} | ||
| </h2> | ||
|
|
||
| {person.age ? <p className="Person__age">{`I am ${person.age}`}</p> : null } |
There was a problem hiding this comment.
just use &&
Suggested change
| {person.age ? <p className="Person__age">{`I am ${person.age}`}</p> : null } | |
| {age && <p className="Person__age">I am {person.age}</p> } |
src/components/Person/Person.jsx
Outdated
Comment on lines
12
to
14
| {person.isMarried | ||
| ? `${person.partnerName} is my ${person.sex === 'm' ? 'wife' : 'husband'}` | ||
| : 'I am not married'} |
loralevitska
approved these changes
Nov 7, 2023
Comment on lines
+13
to
+14
| {isMarried | ||
| ? `${partnerName} is my ${sex === 'm' ? 'wife' : 'husband'}` |
There was a problem hiding this comment.
Avoid nesting ternary
Make a variable for this expression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
demo