React props task 2 #1770
Open
React props task 2 #1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superpooperxxx
suggested changes
Oct 9, 2023
polosanya
suggested changes
Oct 9, 2023
src/components/Person/Person.jsx
Outdated
Comment on lines
4
to
6
| <section className="Person"> | ||
| <h2 className="Person__name">{`My name is ${person.name}`}</h2> | ||
| {person.age && <p className="Person__age">{`I am ${person.age}`}</p>} |
There was a problem hiding this comment.
Suggested change
| <section className="Person"> | |
| <h2 className="Person__name">{`My name is ${person.name}`}</h2> | |
| {person.age && <p className="Person__age">{`I am ${person.age}`}</p>} | |
| <section className="Person"> | |
| <h2 className="Person__name"> | |
| {`My name is ${person.name}`} | |
| </h2> | |
| {person.age && ( | |
| <p className="Person__age"> | |
| {`I am ${person.age}`} | |
| </p> | |
| } |
Fix formatting for better readability
src/components/Person/Person.jsx
Outdated
| {person.age && <p className="Person__age">{`I am ${person.age}`}</p>} | ||
| {person.isMarried ? ( | ||
| <p className="Person__partner"> | ||
| {`${person.partnerName} is my ${person.sex === 'm' ? 'wife' : 'husband'}`} |
There was a problem hiding this comment.
Avoid nesting ternary operators. Let's create a variable for wife/husband
There was a problem hiding this comment.
created isMale boolean variable
superpooperxxx
approved these changes
Oct 11, 2023
| import './Person.scss'; | ||
|
|
||
| export const Person = ({ person }) => { | ||
| const isMale = person.sex === 'm'; |
There was a problem hiding this comment.
I think it is better to save the whole condition with ternary operator to some variable like partner
const partner = person.sex === 'm' ? 'wife' : 'husband';
...
<p className="Person__partner">
{`${person.partnerName} is my ${partner}`}
</p>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ElenaGrasovskaya.github.io/react_person/