Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #443

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #443

wants to merge 1 commit into from

Conversation

Pokhvalenkos
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the Bulls and Cows game! 🎉 Your code meets all the task requirements and is well-structured across different modules. The minor issue with unnecessary conversion using + in logging doesn't impact the functionality, so it's not a blocker. Keep up the good work and continue refining your skills! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

const numberToGuess = generateRandomNumber();
const result = getBullsAndCows(userInput, numberToGuess);

console.log(`Your input: ${+userInput}`);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of +userInput is unnecessary here. Since userInput is already a string, you can directly use it in the template literal: console.log(Your input: ${userInput});.

const result = getBullsAndCows(userInput, numberToGuess);

console.log(`Your input: ${+userInput}`);
console.log(`Number to guess: ${+numberToGuess}`);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of +numberToGuess is unnecessary here. Since numberToGuess is already a string, you can directly use it in the template literal: console.log(Number to guess: ${numberToGuess});.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants