developed #434
developed #434
Conversation
There was a problem hiding this comment.
Great job on implementing the "Bulls & Cows" game! 🎉 Your code meets the task requirements and constraints effectively. While there are a couple of minor improvements suggested, such as ensuring the first digit of the random number isn't zero and converting userInput to a number, these don't significantly impact the functionality. Keep up the good work and consider these suggestions for future enhancements! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| console.log(userInput); | ||
|
|
||
| if (checkIsValidUserInput(userInput)) { | ||
| getBullsAndCows(userInput, numberToGuess); |
There was a problem hiding this comment.
The getBullsAndCows function expects userInput to be a number, but it is currently a string. Consider converting userInput to a number before passing it to the function, for example using parseInt(userInput, 10).
| while (digits.length < 4) { | ||
| const randomDigit = Math.floor(Math.random() * 10); | ||
|
|
||
| if (!digits.includes(randomDigit) && randomDigit !== 0) { |
There was a problem hiding this comment.
The condition randomDigit !== 0 should be applied only when the digits array is empty to ensure the first digit is not 0. Consider separating the logic to handle the first digit differently.
No description provided.