Solution #373
Open
Solution #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedro-ruas
suggested changes
Jun 19, 2024
src/modules/checkIsValidUserInput.js
Outdated
| return false; | ||
| } | ||
|
|
||
| if (userInput[0] === '0') { |
There was a problem hiding this comment.
The 3 if statements could be joint together using an Or operation (||)
src/modules/checkIsValidUserInput.js
Outdated
|
|
||
| const digitSet = new Set(); | ||
|
|
||
| for (let i = 0; i < userInput.length; i++) { |
There was a problem hiding this comment.
Same is valid for both for loops, they can be joint together into a single one.
And can be re-written into a reduce instead, if you want
src/modules/getBullsAndCows.js
Outdated
| } | ||
| } | ||
|
|
||
| for (const digit in userDigitCount) { |
There was a problem hiding this comment.
This works, but seems overcomplicated...
Instead of storing values to objects and them iterating, you could use only a single for loop to solve, why don't you give it a try?
EdPirro
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.