Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PKM Solution 2 #5207

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

PKM Solution 2 #5207

wants to merge 2 commits into from

Conversation

pkmeeks
Copy link

@pkmeeks pkmeeks commented Jan 24, 2025

  • DEMO LINK

  • TEST REPORT LINK

  • there 2 BEM blocks card and stars each in their own file

  • SCSS Nesting is used for elements, modifiers and pseudo-classes

  • SCSS Variables are used for main values and placed in a separate file

  • all stars--N modifiers work as expected (Highlight first N stars)

  • Code follows all the Code Style Rules ❗️

Copy link
Author

@pkmeeks pkmeeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My assignment passed the Backstop tests but are not passing in the github tests. I tried to make changes and run another commit, but not sure how to proceed from here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant