Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #5190

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AleksandraFrangovska
Copy link

  • DEMO LINK

  • TEST REPORT LINK

  • there 2 BEM blocks card and stars each in their own file

  • SCSS Nesting is used for elements, modifiers and pseudo-classes

  • SCSS Variables are used for main values and placed in a separate file

  • all stars--N modifiers work as expected (Highlight first N stars)

  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the task requirements! 🎉 You've structured your code well and met all the core requirements. There are just a couple of minor issues to address in the future: correct the typo in the class name &__discription to &__description, and ensure the font-weight property doesn't have a unit. Keep up the good work! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

width: 100%;
justify-content: space-between;

&__discription {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the class name &__discription. It should be &__description to match the HTML class name and maintain consistency.

height: 40px;
border-radius: 5px;
background-color: $accent-color;
font-weight: 700px;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The font-weight property should not have a unit. It should be font-weight: 700; instead of font-weight: 700px;.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants