Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #5157

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Develop #5157

wants to merge 2 commits into from

Conversation

kondratiukD
Copy link

  • DEMO LINK

  • TEST REPORT LINK

  • there 2 BEM blocks card and stars each in their own file

  • SCSS Nesting is used for elements, modifiers and pseudo-classes

  • SCSS Variables are used for main values and placed in a separate file

  • all stars--N modifiers work as expected (Highlight first N stars)

  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on your implementation! 🎉 The code meets most of the task requirements, and the structure is well-organized. Just a small note: ensure that the stars__starN class name is consistent with your naming conventions unless it's intentionally different. Keep up the good work and happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__starN"></div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class name stars__starN seems inconsistent with the other class names like stars__star. If this is not intentional, consider renaming it to maintain consistency.

background-repeat: no-repeat;
}

&__starN {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class name stars__starN might be inconsistent with the naming convention used for other elements like stars__star. If this is not intentional, consider renaming it to maintain consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants