Develop #5156
Open
Develop #5156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anastasiiadns
commented
Jan 9, 2025
anastasiiadns
commented
- DEMO LINK
- TEST REPORT LINK
mateacademy-ai-mentor
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Great job! 🎉 Your code meets the task requirements and is well-structured. The use of SCSS variables and nesting enhances maintainability. While the stars--N modifiers need a quick check to ensure they highlight the correct number of stars, this is a minor issue. Also, consider reviewing the necessity of the cost.scss file. Keep up the excellent work! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
volodymyr-soltys97
suggested changes
Jan 9, 2025
src/index.html
Outdated
| </div> | ||
| </div> | ||
|
|
||
| <div class="stars"> |
There was a problem hiding this comment.
Add the modifier class
Suggested change
| <div class="stars"> | |
| <div class="stars stars--4"> |
src/index.html
Outdated
Comment on lines
65
to
68
| <div | ||
| class="button" | ||
| data-qa="hover" | ||
| > |
There was a problem hiding this comment.
This wrapper is redundant, use only tag button or a
src/styles/blocks/card.scss
Outdated
Comment on lines
12
to
34
| &__text { | ||
| margin-left: $retreat-margin-left; | ||
| } | ||
|
|
||
| &__text--name { | ||
| margin: 0; | ||
| padding-bottom: 4px; | ||
| padding-top: 35px; | ||
| font-size: 12px; | ||
| width: $tablet-min-width; | ||
| height: 36px; | ||
| font-weight: 500; | ||
| line-height: 18px; | ||
| } | ||
|
|
||
| &__text--description { | ||
| margin: 0; | ||
| font-size: 10px; | ||
| color: #616070; | ||
| height: 14px; | ||
| font-weight: 400; | ||
| line-height: 14px; | ||
| } |
There was a problem hiding this comment.
Use scss nesting, fix it everyhwere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.