pag cartões #5153
pag cartões #5153
Conversation
There was a problem hiding this comment.
Great job on your work! 🎉 The code meets the task requirements and constraints effectively. While there are a few minor issues, such as ensuring all SCSS variables are defined and correcting the <html> tag, these do not significantly impact functionality. Keep up the good work and consider addressing these minor points for even better code quality in the future! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| @@ -1,18 +1,71 @@ | |||
| <!doctype html> | |||
| <html lang="en"> | |||
| <html | |||
There was a problem hiding this comment.
The <html> tag is self-closing, which is incorrect. The <html> tag should not be self-closing. It should be written as <html lang="en" class="page"> without the trailing slash.
| font-weight: 400; | ||
| font-size: 10px; | ||
| line-height: 14px; | ||
| color: $secondary-color; |
There was a problem hiding this comment.
The variable $secondary-color is used here, but it's important to ensure that this variable is defined somewhere in your SCSS files. If it's not defined, it will cause an error during compilation.
| justify-content: space-between; | ||
| align-items: center; | ||
| margin-bottom: 16px; | ||
| line-height: $primary-lineheight; |
There was a problem hiding this comment.
The variable $primary-lineheight is used here, but it's important to ensure that this variable is defined somewhere in your SCSS files. If it's not defined, it will cause an error during compilation.
| align-content: center; | ||
| text-transform: uppercase; | ||
| text-decoration: none; | ||
| background-color: $blue-accent-color; |
There was a problem hiding this comment.
The variable $blue-accent-color is used here, but it's important to ensure that this variable is defined somewhere in your SCSS files. If it's not defined, it will cause an error during compilation.
| .page__body { | ||
| margin: 0; | ||
| font-family: Roboto, serif; | ||
| color: $main-color; |
There was a problem hiding this comment.
The variable $main-color is used here, but it's important to ensure that this variable is defined somewhere in your SCSS files. If it's not defined, it will cause an error during compilation.
[DEMO LINK] (https://nataliaso23.github.io/layout_product-cards/)
[TEST REPORT LINK] (https://nataliaso23.github.io/layout_product-cards/report/html_report/)
[x ] there 2 BEM blocks
cardandstarseach in their own file[x ] SCSS Nesting is used for
elements,modifiersandpseudo-classes[x ] SCSS Variables are used for main values and placed in a separate file
[ x] all
stars--Nmodifiers work as expected (Highlight firstNstars)[x ] Code follows all the [Code Style Rules ❗️]