Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #5146

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Develop #5146

wants to merge 2 commits into from

Conversation

denisproger
Copy link

mateacademy-ai-mentor
mateacademy-ai-mentor suggested changes Jan 6, 2025
View reviewed changes
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your hard work on this project! 😊 While your code is well-structured and mostly meets the task requirements, there are a few critical issues that need to be addressed before we can proceed:

  1. SCSS Variables: Please ensure that SCSS variables are used for main values and placed in a separate file as required by the task.

  2. BEM Blocks: The task specifies that there should be two BEM blocks, card and stars, each in their own file. Please ensure that each BEM block is in its own SCSS file.

  3. SCSS Nesting: Make sure to utilize SCSS nesting for elements, modifiers, and pseudo-classes as required.

  4. Image Paths: Update the background-image paths to be relative to index.scss and start with ../images.

These changes are important to meet the core requirements of the task. Once these are addressed, your implementation will be ready to go! Keep up the great work, and feel free to reach out if you have any questions or need further assistance. 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

@denisproger
Copy link
Author

I have no idea how to fix that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateacademy-ai-mentor mateacademy-ai-mentor mateacademy-ai-mentor requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denisproger @mateacademy-ai-mentor