Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add product-card #5144

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add product-card #5144

wants to merge 2 commits into from

Conversation

AnoriFrell
Copy link

  • DEMO LINK

  • TEST REPORT LINK

  • there 2 BEM blocks card and stars each in their own file

  • SCSS Nesting is used for elements, modifiers and pseudo-classes

  • SCSS Variables are used for main values and placed in a separate file

  • all stars--N modifiers work as expected (Highlight first N stars)

  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Thank you for your hard work on this project! 😊 While your solution is on the right track, there are a few critical issues that need to be addressed before we can approve the pull request.

  1. BEM Blocks: The task requires separate files for the card and stars BEM blocks. Currently, the stars block is integrated into the card block within the index.scss file, and there is no separate file for the stars block. This is a core requirement that needs to be resolved.

  2. SCSS Variables: The task specifies that SCSS variables should be placed in a separate file. Currently, they are defined within the index.scss file. Moving them to a dedicated file will enhance maintainability and is necessary to meet the task requirements.

  3. Stars Modifiers: The implementation of stars--N modifiers is missing. These modifiers are essential for highlighting the first N stars, as specified in the task requirements.

These issues are critical as they directly relate to the core requirements of the task. Once these are addressed, your solution will be much stronger. Keep up the great work, and feel free to reach out if you need any help! 🌟

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

Comment on lines 102 to 103
&-number {
font-size: 16;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The font-size value should include a unit (e.g., 'px', 'em'). Currently, it is missing, which might lead to unexpected behavior.

align-items: center;
width: 100%;
border: 1px solid $button-bcg-color;
border-radius: 5;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The border-radius value should include a unit (e.g., 'px'). Currently, it is missing, which might lead to unexpected behavior.

&--styles {
text-transform: uppercase;
text-decoration: none;
font-size: 14;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The font-size value should include a unit (e.g., 'px', 'em'). Currently, it is missing, which might lead to unexpected behavior.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on your progress so far! 🎉 While there are a few areas that need improvement, such as separating the stars BEM block into its own SCSS file and moving SCSS variables to a dedicated file, your effort is commendable. These changes will enhance the maintainability and organization of your code. Remember to implement the stars--N modifiers to meet the task requirements fully. Keep up the good work, and use this feedback to refine your skills. Addressing these issues will help you avoid similar problems in the future. Keep learning and improving! 💪

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines 22 to 24
<link
rel="stylesheet"
href="./styles/index.scss"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the SCSS file linked here (index.scss) is structured according to the task requirements. Specifically, check that the card and stars BEM blocks are in separate files, and SCSS variables are placed in a dedicated file.

Comment on lines +1 to +7
$font-color-main: #060b35;
$font-color-secondary: #616070;
$button-bcg-color: #00acdc;
$button-hover-bcg-color: #fff;
$text-hover-color: #00acdc;
$text-color: #fff;
$card-border-color: #f3f3f3;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SCSS variables should be moved to a separate file dedicated to variables, as per the task requirements. This will enhance maintainability and organization.

Comment on lines +54 to +86
&__stars-container {
display: flex;
}

&__stars {
display: flex;
justify-content: space-between;
padding-top: 16px;

&-star {
background-image: url(../images/star-active.svg);
background-repeat: no-repeat;
background-position: center;
width: 16px;
height: 16px;

&:last-of-type {
background-image: url(../images/star.svg);
}

&:not(:last-of-type) {
margin-right: 4px;
}
}

&-reviews {
align-self: flex-end;
font-size: 10px;
font-weight: 400;
line-height: 14px;
color: $font-color-main;
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stars BEM block should be moved to a separate SCSS file. The task requires separate files for each BEM block, which helps in maintaining a clear structure and organization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants