-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add product-card #5144
base: master
Are you sure you want to change the base?
add product-card #5144
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your hard work on this project! 😊 While your solution is on the right track, there are a few critical issues that need to be addressed before we can approve the pull request.
-
BEM Blocks: The task requires separate files for the
card
andstars
BEM blocks. Currently, thestars
block is integrated into thecard
block within theindex.scss
file, and there is no separate file for thestars
block. This is a core requirement that needs to be resolved. -
SCSS Variables: The task specifies that SCSS variables should be placed in a separate file. Currently, they are defined within the
index.scss
file. Moving them to a dedicated file will enhance maintainability and is necessary to meet the task requirements. -
Stars Modifiers: The implementation of
stars--N
modifiers is missing. These modifiers are essential for highlighting the firstN
stars, as specified in the task requirements.
These issues are critical as they directly relate to the core requirements of the task. Once these are addressed, your solution will be much stronger. Keep up the great work, and feel free to reach out if you need any help! 🌟
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
src/styles/index.scss
Outdated
&-number { | ||
font-size: 16; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The font-size value should include a unit (e.g., 'px', 'em'). Currently, it is missing, which might lead to unexpected behavior.
src/styles/index.scss
Outdated
align-items: center; | ||
width: 100%; | ||
border: 1px solid $button-bcg-color; | ||
border-radius: 5; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The border-radius value should include a unit (e.g., 'px'). Currently, it is missing, which might lead to unexpected behavior.
src/styles/index.scss
Outdated
&--styles { | ||
text-transform: uppercase; | ||
text-decoration: none; | ||
font-size: 14; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The font-size value should include a unit (e.g., 'px', 'em'). Currently, it is missing, which might lead to unexpected behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on your progress so far! 🎉 While there are a few areas that need improvement, such as separating the stars
BEM block into its own SCSS file and moving SCSS variables to a dedicated file, your effort is commendable. These changes will enhance the maintainability and organization of your code. Remember to implement the stars--N
modifiers to meet the task requirements fully. Keep up the good work, and use this feedback to refine your skills. Addressing these issues will help you avoid similar problems in the future. Keep learning and improving! 💪
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
<link | ||
rel="stylesheet" | ||
href="./styles/index.scss" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the SCSS file linked here (index.scss
) is structured according to the task requirements. Specifically, check that the card
and stars
BEM blocks are in separate files, and SCSS variables are placed in a dedicated file.
$font-color-main: #060b35; | ||
$font-color-secondary: #616070; | ||
$button-bcg-color: #00acdc; | ||
$button-hover-bcg-color: #fff; | ||
$text-hover-color: #00acdc; | ||
$text-color: #fff; | ||
$card-border-color: #f3f3f3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SCSS variables should be moved to a separate file dedicated to variables, as per the task requirements. This will enhance maintainability and organization.
&__stars-container { | ||
display: flex; | ||
} | ||
|
||
&__stars { | ||
display: flex; | ||
justify-content: space-between; | ||
padding-top: 16px; | ||
|
||
&-star { | ||
background-image: url(../images/star-active.svg); | ||
background-repeat: no-repeat; | ||
background-position: center; | ||
width: 16px; | ||
height: 16px; | ||
|
||
&:last-of-type { | ||
background-image: url(../images/star.svg); | ||
} | ||
|
||
&:not(:last-of-type) { | ||
margin-right: 4px; | ||
} | ||
} | ||
|
||
&-reviews { | ||
align-self: flex-end; | ||
font-size: 10px; | ||
font-weight: 400; | ||
line-height: 14px; | ||
color: $font-color-main; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The stars
BEM block should be moved to a separate SCSS file. The task requires separate files for each BEM block, which helps in maintaining a clear structure and organization.
DEMO LINK
TEST REPORT LINK
there 2 BEM blocks
card
andstars
each in their own fileSCSS Nesting is used for
elements
,modifiers
andpseudo-classes
SCSS Variables are used for main values and placed in a separate file
all
stars--N
modifiers work as expected (Highlight firstN
stars)Code follows all the Code Style Rules ❗️