-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #5143
base: master
Are you sure you want to change the base?
add task solution #5143
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on meeting most of the task requirements! 🎉 While there are a few minor issues like the invalid href
attribute on the <button>
, redundant font-weight
declarations, and the incorrect font-style
property, these don't significantly impact the functionality. Keep up the good work and consider addressing these points for cleaner code in the future! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
<button | ||
class="card__button" | ||
data-qa="hover" | ||
href="#buy" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The href
attribute is not valid for a <button>
element. If you want to link to another section or page, consider using an <a>
tag instead, or handle the navigation with JavaScript.
font-weight: 700; | ||
font-weight: bold; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The font-weight
property is defined twice for the &-amount
class. You should remove one of these declarations to avoid redundancy. Consider keeping font-weight: bold;
as it is more descriptive.
font-family: Roboto, sans-serif; | ||
src: url('/src/fonts/Roboto-Bold.ttf') format('truetype'); | ||
font-weight: bold; | ||
font-style: bold; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The font-style
property should not be set to bold
. Instead, it should be normal
or italic
. Since this is a bold font, you should set font-style: normal;
.
DEMO LINK
TEST REPORT LINK
❗️ Copy this
Checklist
to thePull Request
description after links, and put- [x]
before each point after you checked it.there 2 BEM blocks
card
andstars
each in their own fileSCSS Nesting is used for
elements
,modifiers
andpseudo-classes
SCSS Variables are used for main values and placed in a separate file
all
stars--N
modifiers work as expected (Highlight firstN
stars)Code follows all the Code Style Rules ❗️