Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #5143

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add task solution #5143

wants to merge 1 commit into from

Conversation

DSOst
Copy link

@DSOst DSOst commented Jan 5, 2025

  • DEMO LINK

  • TEST REPORT LINK

  • ❗️ Copy this Checklist to the Pull Request description after links, and put - [x] before each point after you checked it.

  • there 2 BEM blocks card and stars each in their own file

  • SCSS Nesting is used for elements, modifiers and pseudo-classes

  • SCSS Variables are used for main values and placed in a separate file

  • all stars--N modifiers work as expected (Highlight first N stars)

  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on meeting most of the task requirements! 🎉 While there are a few minor issues like the invalid href attribute on the <button>, redundant font-weight declarations, and the incorrect font-style property, these don't significantly impact the functionality. Keep up the good work and consider addressing these points for cleaner code in the future! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +50 to +53
<button
class="card__button"
data-qa="hover"
href="#buy"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute is not valid for a <button> element. If you want to link to another section or page, consider using an <a> tag instead, or handle the navigation with JavaScript.

Comment on lines +65 to +66
font-weight: 700;
font-weight: bold;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The font-weight property is defined twice for the &-amount class. You should remove one of these declarations to avoid redundancy. Consider keeping font-weight: bold; as it is more descriptive.

font-family: Roboto, sans-serif;
src: url('/src/fonts/Roboto-Bold.ttf') format('truetype');
font-weight: bold;
font-style: bold;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The font-style property should not be set to bold. Instead, it should be normal or italic. Since this is a bold font, you should set font-style: normal;.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants