Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added card #5142

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

added card #5142

wants to merge 2 commits into from

Conversation

kbnd
Copy link

@kbnd kbnd commented Jan 4, 2025

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your hard work on this project! 😊 There are a few critical issues that need to be addressed before we can approve the pull request. Specifically, the task requires SCSS variables to be placed in a separate file, and the stars block needs to be implemented in its own SCSS file. Additionally, the image paths should be relative, and the crossorigin attribute in your HTML file needs correction. Please make these changes to ensure your code meets the core requirements. Keep up the great effort, and I'm confident you'll nail it with these adjustments! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

src/index.html Outdated
<link
rel="preconnect"
href="https://fonts.gstatic.com"
crossorigin="attr-req-value"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The crossorigin attribute value is incorrect. It should be either 'anonymous' or 'use-credentials'.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on addressing many of the previous issues! 🎉 However, there are still a few critical points that need attention to ensure your code meets all the core requirements:

  1. SCSS Variables File: You've correctly placed the SCSS variables in a separate file named variables.scss. Well done!

  2. Stars Block SCSS File: The stars block is implemented in its own SCSS file named stars.scss. However, please ensure that the image paths within this file are relative, such as changing /src/images/star-active.svg and /src/images/star.svg to ../images/star-active.svg and ../images/star.svg respectively.

  3. Image Paths: In the index.html file, make sure that the image paths are relative. For example, change /src/images/imac.jpeg to ./images/imac.jpeg.

  4. Crossorigin Attribute: The crossorigin attribute is missing in the HTML file for the Google Fonts link. Add crossorigin="anonymous" to ensure proper font loading.

  5. SCSS Import Paths: Ensure that the import paths for SCSS files are relative. Change '/src/styles/stars' to './stars' and '/src/styles/variables' to './variables'.

By addressing these issues, you'll ensure that your code is robust and adaptable to different environments. Keep up the great work, and continue learning from these experiences to enhance your coding skills! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

data-qa="card"
>
<img
src="/src/images/imac.jpeg"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image path should be relative to ensure it works correctly in different environments. Please change /src/images/imac.jpeg to a relative path like ./images/imac.jpeg.

/>
<link
rel="preconnect"
href="https://fonts.gstatic.com"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The crossorigin attribute is missing for the Google Fonts link. Add crossorigin="anonymous" to ensure proper font loading.

@@ -1,3 +1,104 @@
@import '/src/styles/variables';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path for the SCSS variables should be relative. Change '/src/styles/variables' to './variables'.

@@ -1,3 +1,104 @@
@import '/src/styles/variables';
@import '/src/styles/stars';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path for the SCSS stars should be relative. Change '/src/styles/stars' to './stars'.

&__star {
width: 16px;
height: 16px;
background-image: url(/src/images/star.svg);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image path should be relative to ensure it works correctly in different environments. Please change /src/images/star.svg to a relative path like ../images/star.svg.

}

&__star:nth-child(-n + 4) {
background-image: url(/src/images/star-active.svg);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image path should be relative to ensure it works correctly in different environments. Please change /src/images/star-active.svg to a relative path like ../images/star-active.svg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants