product-cards

[greyhoundIlya]

• DEMO LINK
• TEST REPORT LINK

[mateacademy-ai-mentor]

---

Thank you for your hard work on this project! 😊 There are a couple of critical issues that need to be addressed before we can approve the pull request:

1. BEM Blocks Separation: The requirement specifies that the card and stars BEM blocks should be in their own separate files. Please ensure these blocks are correctly separated to meet the task requirements.

2. Stars Block: The task requires the stars block to be rewritten using SCSS. Please verify and update this block as needed to fulfill the requirement.

3. Class Name Typo: There's a minor typo in the class name card-imge. It should be corrected to card-image to ensure styles are applied correctly.

Once these issues are resolved, your code will be in great shape! Keep up the great work, and feel free to reach out if you have any questions or need further assistance. 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

[mateacademy-ai-mentor]

There is a typo in the class name card-imge. It should be card-image to match the HTML class name and ensure styles are applied correctly.

[mateacademy-ai-mentor]

Thank you for your submission! 🎉 While your code is generally well-structured, there are a few critical issues that need attention to enhance its functionality and maintainability.

1. BEM Blocks Separation: Ensure that the card and stars BEM blocks are separated into their own files as per the task requirements. This will help in maintaining a clean and organized codebase.

2. SCSS Compilation: Avoid linking SCSS files directly in HTML. Instead, use the Parcel bundler to compile SCSS into CSS. This will ensure that your styles are applied correctly and efficiently.

3. Typo in Variable Name: Correct the typo in the SCSS variable name from $colors-backgraund to $colors-background to ensure the intended styles are applied.

These improvements are crucial for the functionality and clarity of your code. Please address these issues in future submissions to avoid similar problems. Keep up the good work and continue learning from these experiences! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

[mateacademy-ai-mentor]

Linking SCSS files directly in HTML is not recommended as the Parcel bundler should handle the compilation. Ensure that the SCSS files are compiled into CSS files by Parcel.

[mateacademy-ai-mentor]

Similar to the previous comment, ensure that SCSS files are compiled into CSS by the Parcel bundler instead of linking them directly in HTML.

[mateacademy-ai-mentor]

There's a typo in the variable name $colors-backgraund. It should be $colors-background to ensure clarity and consistency.

[mateacademy-ai-mentor]

The variable $colors-backgraund contains a typo. It should be $colors-background to match the corrected variable name in change.scss.

[mateacademy-ai-mentor]

Ensure the variable $colors-backgraund is corrected to $colors-background to apply the intended background color.